Skip to content

DM-11350 PointSelect Marker can not be added after the overlay layer is deleted #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2017
Merged

DM-11350 PointSelect Marker can not be added after the overlay layer is deleted #446

merged 1 commit into from
Aug 23, 2017

Conversation

cwang2016
Copy link
Contributor

this development includes:

  • disallow the user to delete the PointSelect overlay from the overlay dialog.
  • adjust the layout of 'color', 'symbol' and 'delete' link on the overlay dialog.

Test:

  • get an image from firefly or time series tool
  • check 'Lock on click', the 'Overlay display' icon is shown with '2' on the corner,
  • add a PointSelect marker on the image, and click the 'Overlay display' icon, the PointSelect is not deletable from the overlay manipulation dialog.
  • add other overlay layers to see the arrangement of 'color', 'symbol', and 'Delete' on the overlay dialog.
  • delete the PointSelect overlay by un-checking 'Lock by click'

@cwang2016 cwang2016 self-assigned this Aug 21, 2017
@cwang2016 cwang2016 requested a review from robyww August 21, 2017 22:22
robyww
robyww approved these changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think the layout is better than before, however I don't really like it (not sure why and don't have any good ideas). We might get some feedback down the road where we have to do more work on it.

@cwang2016 cwang2016 merged commit e7c7864 into dev Aug 23, 2017
@cwang2016 cwang2016 deleted the DM-11350-TSAddMarker branch August 23, 2017 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyww robyww robyww approved these changes

Assignees

@cwang2016 cwang2016

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwang2016 @robyww